Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase hardware version to 21 #2038

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Increase hardware version to 21 #2038

merged 2 commits into from
Oct 12, 2023

Conversation

schneif2
Copy link
Contributor

Description

Fixes: #2036

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

Release Note

Release note for CHANGELOG:

Fixes #2036 - r/vsphere_virtual_machine increase hardware_version to 21

References

Increase virtual_machine hardware_version to 21

@schneif2 schneif2 requested a review from a team as a code owner October 12, 2023 15:21
@hashicorp-cla
Copy link

hashicorp-cla commented Oct 12, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added documentation Type: Documentation provider Type: Provider size/xs Relative Sizing: Extra-Small labels Oct 12, 2023
tenthirtyam
tenthirtyam approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iBrandyJackson iBrandyJackson merged commit fc3757a into hashicorp:main Oct 12, 2023
5 checks passed
@tenthirtyam tenthirtyam added this to the v2.5.1 milestone Oct 12, 2023
@github-actions
Copy link

This functionality has been released in v2.5.1 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tenthirtyam tenthirtyam tenthirtyam approved these changes

@iBrandyJackson iBrandyJackson iBrandyJackson approved these changes

@vasilsatanasov vasilsatanasov Awaiting requested review from vasilsatanasov

Assignees
No one assigned
Labels
documentation Type: Documentation provider Type: Provider size/xs Relative Sizing: Extra-Small
Projects
None yet
Milestone
v2.5.1
Development

Successfully merging this pull request may close these issues.

Increase virtual_machine hardware_version to 21
4 participants
@schneif2 @hashicorp-cla @tenthirtyam @iBrandyJackson