Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: add 1.2 lifecycle replace_triggered_by attribute #123

Merged
merged 2 commits into from
Jul 8, 2022

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Jul 7, 2022

Fixes #107

See https://github.com/hashicorp/terraform/blob/v1.2/CHANGELOG.md#120-may-18-2022 and https://www.terraform.io/language/meta-arguments/lifecycle#replace_triggered_by

This will be useful to get merged before hashicorp/terraform-ls#993 in case we need to restructure the existing schemas in any more significant way.


LS UX

Screenshot 2022-07-07 at 09 05 21

Screenshot 2022-07-07 at 09 05 46

@radeksimko radeksimko added the enhancement New feature or request label Jul 7, 2022
@radeksimko radeksimko changed the title schema: add 1.2 lifecycle 'replace_triggered_by' attribute schema: add 1.2 lifecycle replace_triggered_by attribute Jul 7, 2022
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Is there any convention for structuring these schema files? I noticed that for most other versions, the root.go only contains ModuleSchema, and additional files contain the modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reflect lifecycle replace_triggered_by
2 participants