Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project attribute to workspaces block #257

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Add project attribute to workspaces block #257

merged 3 commits into from
Sep 26, 2023

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Sep 25, 2023

Closes #206

Example UX

Screenshot 2023-09-25 at 14 44 33

Screenshot 2023-09-25 at 14 44 46

@dbanck dbanck added the enhancement New feature or request label Sep 25, 2023
@dbanck dbanck requested a review from a team as a code owner September 25, 2023 13:18
@dbanck dbanck self-assigned this Sep 25, 2023
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the descriptions as mentioned in-line.

Side note:
We will also need to regenerate the versions here to "expose" it

OldestAvailableVersion = version.Must(version.NewVersion("0.12.0"))
LatestAvailableVersion = version.Must(version.NewVersion("1.5.0"))
terraformVersions = version.Collection{
version.Must(version.NewVersion("1.5.0")),

And on a related note, we probably shouldn't be setting beta versions as latest when generating the file, meaning that we should be able to provide schema relevant to pre-releases such as 1.6.0-beta3 but only if the configuration explicitly opts into it or the user has installed that version, otherwise we should assume latest stable version. I'm happy to file this as a separate issue or raise a PR unless you plan to do it (obviously not part of this PR either way).

internal/schema/1.6/terraform.go Outdated Show resolved Hide resolved
internal/schema/1.6/terraform.go Outdated Show resolved Hide resolved
internal/schema/1.6/terraform.go Outdated Show resolved Hide resolved
@dbanck
Copy link
Member Author

dbanck commented Sep 25, 2023

Side note: We will also need to regenerate the versions here to "expose" it

I added a TODO for later this week to regenerate the versions :)

Co-authored-by: Radek Simko <radek.simko@gmail.com>
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dbanck dbanck merged commit 4a7fa2c into main Sep 26, 2023
5 checks passed
@dbanck dbanck deleted the f-cloud-project branch September 26, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support v1.6 cloud project attribute
2 participants