Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip inferring module inputs for default values #289

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Oct 27, 2023

After removing type inference from default values in hashicorp/hcl-lang#338, this PR does the same for module inputs. These also previously relied on variable defaults to get a type for a module input.

Without this, we can now pass a list of strings to tuple defaults, etc.

UX Before

CleanShot 2023-11-02 at 14 55 10@2x

UX After

CleanShot 2023-11-02 at 14 55 32@2x CleanShot 2023-11-02 at 14 59 34@2x

@dbanck dbanck added the bug Something isn't working label Oct 27, 2023
@dbanck dbanck self-assigned this Oct 27, 2023
@dbanck dbanck force-pushed the b-update-module-input-infer branch 2 times, most recently from 11c12a7 to c38c4b5 Compare November 1, 2023 16:56
@dbanck dbanck changed the title Skip inferring module inputs for [] and {} default values Skip inferring module inputs for default values Nov 1, 2023
@dbanck dbanck force-pushed the b-update-module-input-infer branch from c38c4b5 to c7efbd7 Compare November 2, 2023 13:27
@dbanck dbanck marked this pull request as ready for review November 2, 2023 14:04
@dbanck dbanck requested a review from a team as a code owner November 2, 2023 14:04
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dbanck dbanck merged commit 535af8a into main Nov 2, 2023
5 checks passed
@dbanck dbanck deleted the b-update-module-input-infer branch November 2, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable with empty list causes "No declaration found" on submodules
2 participants