Skip inferring module inputs for default values #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanck
force-pushed
the
b-update-module-input-infer
branch
2 times, most recently
from
11c12a7
to
c38c4b5
Compare
dbanck
changed the title
[] and {} default values
dbanck
force-pushed
the
b-update-module-input-infer
branch
from
c38c4b5
to
c7efbd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After removing type inference from default values in hashicorp/hcl-lang#338, this PR does the same for module inputs. These also previously relied on variable defaults to get a type for a module input.
Without this, we can now pass a list of strings to tuple defaults, etc.
UX Before
UX After