Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws Return service CIDR blocks from aws_vpc_endpoint resource #10254

Merged
merged 1 commit into from Nov 21, 2016
Merged

provider/aws Return service CIDR blocks from aws_vpc_endpoint resource #10254

merged 1 commit into from Nov 21, 2016

Conversation

ewbankkit
Copy link
Contributor

Return the list of CIDR blocks for the service exposed through an AWS VPC Endpoint.
Updated documentation.
Updated acceptance test:

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSVpcEndpoint_basic'

@stack72
Copy link
Contributor

stack72 commented Nov 21, 2016

This is a nice addition - thanks for the work here @ewbankkit

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSVpcEndpoint_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/11/21 10:34:39 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSVpcEndpoint_ -timeout 120m
=== RUN   TestAccAWSVpcEndpoint_importBasic
--- PASS: TestAccAWSVpcEndpoint_importBasic (155.07s)
=== RUN   TestAccAWSVpcEndpoint_basic
--- PASS: TestAccAWSVpcEndpoint_basic (71.09s)
=== RUN   TestAccAWSVpcEndpoint_withRouteTableAndPolicy
--- PASS: TestAccAWSVpcEndpoint_withRouteTableAndPolicy (124.84s)
=== RUN   TestAccAWSVpcEndpoint_WithoutRouteTableOrPolicyConfig
--- PASS: TestAccAWSVpcEndpoint_WithoutRouteTableOrPolicyConfig (72.15s)
=== RUN   TestAccAWSVpcEndpoint_removed
--- PASS: TestAccAWSVpcEndpoint_removed (52.78s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	475.954s

@stack72 stack72 merged commit 7330d65 into hashicorp:master Nov 21, 2016
@ewbankkit ewbankkit deleted the aws-vpce-resource-cidr-blocks branch November 21, 2016 23:18
gusmat pushed a commit to gusmat/terraform that referenced this pull request Dec 6, 2016
fatmcgav pushed a commit to fatmcgav/terraform that referenced this pull request Feb 27, 2017
@ghost
Copy link

ghost commented Apr 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@hashicorp hashicorp locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants