Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip VPC endpoint routes when removing default route table's routes #10303

Merged
merged 1 commit into from
Nov 23, 2016
Merged

Skip VPC endpoint routes when removing default route table's routes #10303

merged 1 commit into from
Nov 23, 2016

Conversation

ewbankkit
Copy link
Contributor

Fixes #10295.
Added an acceptance test:

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSDefaultRouteTable_'

@stack72
Copy link
Contributor

stack72 commented Nov 23, 2016

This LGTM! Thanks for the work here @ewbankkit

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=estAccAWSDefaultRouteTable_'           1 ↵
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/11/23 13:05:08 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=estAccAWSDefaultRouteTable_ -timeout 120m
=== RUN   TestAccAWSDefaultRouteTable_basic
--- PASS: TestAccAWSDefaultRouteTable_basic (91.49s)
=== RUN   TestAccAWSDefaultRouteTable_swap
--- PASS: TestAccAWSDefaultRouteTable_swap (116.96s)
=== RUN   TestAccAWSDefaultRouteTable_vpc_endpoint
--- PASS: TestAccAWSDefaultRouteTable_vpc_endpoint (72.97s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	281.428s

@stack72 stack72 merged commit 7319968 into hashicorp:master Nov 23, 2016
@ewbankkit ewbankkit deleted the issue-10295 branch November 23, 2016 21:00
@ghost
Copy link

ghost commented Apr 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_default_route_table resource crash with routes to VPC endpoints
2 participants