Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make resource_newrelic_alert_condition enabled status configurable #11123

Closed
garthkerr opened this issue Jan 9, 2017 · 5 comments
Closed

Make resource_newrelic_alert_condition enabled status configurable #11123

garthkerr opened this issue Jan 9, 2017 · 5 comments

Comments

@garthkerr
Copy link

Terraform Version

v0.8.2

Affected Resource(s)

  • resource_newrelic_alert_condition

The newrelic resource module by @paultyng is outstanding thus far. However, is would be useful to make the enabled status a configurable argument:

@paultyng
Copy link
Contributor

I may not be remembering it correctly, its worth a test, but there were some things I found where the API didn't respect changes to the fields, this may be one of them. Their API is pretty bad, missing endpoints, not an up to date swagger spec, etc. I tried to smooth over as many of the edges as I could.

@paultyng
Copy link
Contributor

Actually, it may have been a bug in my SDK library now that I look at it.

https://github.com/paultyng/go-newrelic/blob/37814ca9c24a7e5f9455c7e71a79b6732bab1912/api/types.go#L55

Since this is omitempty and false is the empty value for boolean. So would need to change that probably.

@paultyng
Copy link
Contributor

I wrote an issue up for that paultyng/go-newrelic#2

@garthkerr
Copy link
Author

Thank you for the details on this @paultyng

@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants