provider/docker: added support for linux capabilities

[dmportella]

Refs #11623

Added capabilities block
Added tests for it
Added documentation for it.

My PC doesn't support memory swap so it errors there.

$ make testacc TEST=./builtin/providers/docker TESTARGS='-run=TestAccDockerContainer_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/02/17 14:57:08 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/docker -v -run=TestAccDockerContainer_ -timeout 120m
=== RUN   TestAccDockerContainer_basic
--- PASS: TestAccDockerContainer_basic (44.50s)
=== RUN   TestAccDockerContainer_volume
--- PASS: TestAccDockerContainer_volume (40.73s)
=== RUN   TestAccDockerContainer_customized
--- FAIL: TestAccDockerContainer_customized (50.27s)
	testing.go:265: Step 0 error: Check failed: Check 2/2 error: Container has wrong memory swap setting: -1
	Please check that you machine supports memory swap (you can do that by running 'docker info' command).
=== RUN   TestAccDockerContainer_upload
--- PASS: TestAccDockerContainer_upload (38.56s)
FAIL
exit status 1
FAIL	github.com/hashicorp/terraform/builtin/providers/docker	174.070s
Makefile:48: recipe for target 'testacc' failed
make: *** [testacc] Error 1

[dmportella]

I am just updating some of the documentation now... Also I wanted to ask something I wasnt sure how to add a block that is not repeatable. So I added a TypeSet block for the capabilities but I only read the first one

[dmportella]

this is what i mean - I wasnt sure how to make a block that can not be repeated. alternatively I could change the resource so it is just two set of string lists. like

Instead of the above:

add-capabilities =  ["ALL"]
drop-capabilities = ["SYS_ADMIN"]

[dmportella]

I prefer my original entry

[dmportella]

let me know if there anything else

[stack72]

Hi @dmportella

Thanks for the work here - I am not sure I understand what you are asking about

add-capabilities = ["ALL"]

?

Paul

[dmportella]

@stack72 no worries

what i meant was. I created a section on the resource called capabilities and can be entered like this

resource "docker_container" "hello" {
	name = "tf-test"
	image = "hellow-world"
	capabilities {
		add= ["ALL"]
		drop = ["SYS_ADMIN"]
	}
}

but the way the resource section are done it allows the user to enter multiple copies of it.

resource "docker_container" "hello" {
	name = "tf-test"
	image = "hellow-world"
	capabilities {
		add= ["ALL"]
	}
	capabilities {
		add= ["ALL"]
	}
	capabilities {
		add= ["ALL"]
	}
}

In the code i just select the zero index but i wanted to know if there was a way to describe the resources so there can be only one.

[stack72]

@dmportella

I got ya - if you make the schema look like this:

			"capabilities": &schema.Schema{
				Type:     schema.TypeSet,
				Optional: true,
				ForceNew: true,
        MaxItems: 1,
				Elem: &schema.Resource{

That will take care of it for you

[dmportella]

awesome
will do

[dmportella]

Added the max items now.

Test rerun so all good from my end

make testacc TEST=./builtin/providers/docker TESTARGS='-run=TestAccDockerContainer_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/03/07 16:38:46 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/docker -v -run=TestAccDockerContainer_ -timeout 120m
=== RUN   TestAccDockerContainer_basic
--- PASS: TestAccDockerContainer_basic (21.11s)
=== RUN   TestAccDockerContainer_volume
--- PASS: TestAccDockerContainer_volume (19.12s)
=== RUN   TestAccDockerContainer_customized
--- FAIL: TestAccDockerContainer_customized (29.76s)
	testing.go:265: Step 0 error: Check failed: Check 2/2 error: Container has wrong memory swap setting: -1
	Please check that you machine supports memory swap (you can do that by running 'docker info' command).
=== RUN   TestAccDockerContainer_upload
--- PASS: TestAccDockerContainer_upload (20.74s)
FAIL
exit status 1
FAIL	github.com/hashicorp/terraform/builtin/providers/docker	90.742s
Makefile:48: recipe for target 'testacc' failed
make: *** [testacc] Error 1

[stack72]

LGMT! Will merge when it goes green :) Thanks for the work on this

[dmportella]

no worries its cool - i keep an eye on the issues when i have some time i do some tickets ;)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.