Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Import to the Google network resource #13834

Merged
merged 1 commit into from Apr 21, 2017

Conversation

skalle
Copy link
Contributor

@skalle skalle commented Apr 21, 2017

Adding import for the compute network.

@stack72
Copy link
Contributor

stack72 commented Apr 21, 2017

Hi @skalle

Thanks so much for the work here - this LGTM and the tests pass as expected. I will add the documentation for this locally and push it to the repository. The tests pass locally :)

% make testacc TEST=./builtin/providers/google TESTARGS='-run=TestAccComputeNetwork_'                                         ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/21 12:41:48 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccComputeNetwork_ -timeout 120m
=== RUN   TestAccComputeNetwork_importBasic
--- PASS: TestAccComputeNetwork_importBasic (67.18s)
=== RUN   TestAccComputeNetwork_importAuto_subnet
--- PASS: TestAccComputeNetwork_importAuto_subnet (117.86s)
=== RUN   TestAccComputeNetwork_importCustom_subnet
--- PASS: TestAccComputeNetwork_importCustom_subnet (68.32s)
=== RUN   TestAccComputeNetwork_basic
--- PASS: TestAccComputeNetwork_basic (65.61s)
=== RUN   TestAccComputeNetwork_auto_subnet
--- PASS: TestAccComputeNetwork_auto_subnet (117.25s)
=== RUN   TestAccComputeNetwork_custom_subnet
--- PASS: TestAccComputeNetwork_custom_subnet (65.74s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/google	501.984s

@stack72 stack72 merged commit 3af9aa2 into hashicorp:master Apr 21, 2017
@ghost
Copy link

ghost commented Apr 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@hashicorp hashicorp locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants