provider/aws: Expose execution ARN + invoke URL for APIG deployment

[radeksimko]

The URL is useful for humans wanting to call the URL easily straight away and ARN for Lambda Permission.

Before

resource "aws_lambda_permission" "apigw_lambda" {
  statement_id  = "AllowExecutionFromAPIGateway"
  action        = "lambda:InvokeFunction"
  function_name = "${aws_lambda_function.lambda.arn}"
  principal     = "apigateway.amazonaws.com"

  source_arn = "arn:aws:execute-api:${var.region}:${var.account_id}:${aws_api_gateway_rest_api.demo.id}/${var.stage_name}/*"
}

output "invoke_url" {
  value = "https://${aws_api_gateway_rest_api.demo.id}.execute-api.${var.region}.amazonaws.com/${var.stage_name}"
}

After

resource "aws_lambda_permission" "apigw_lambda" {
  statement_id  = "AllowExecutionFromAPIGateway"
  action        = "lambda:InvokeFunction"
  function_name = "${aws_lambda_function.lambda.arn}"
  principal     = "apigateway.amazonaws.com"

  source_arn = "${aws_api_gateway_deployment.demo.execution_arn}/*"
}

output "invoke_url" {
  value = "${aws_api_gateway_deployment.demo.invoke_url}"
}

[stack72]

Will this also need noted as an incompatibility?

[radeksimko]

@stack72 🤔 not sure I understand how could this change be incompatible with anything? We're introducing 2 new fields which users may or may not want to use.

[stack72]

My apologies that it's a new field :)

[stack72]

LGTM!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.