Adding import for the compute_route resource

[skalle]

Chipping away at the resource imports.

[grubernaut]

Code looks good, couple of minor nits.

[grubernaut]

Add a newline here after the first resource.TestStep object.

},
{

[grubernaut]

Same here

[grubernaut]

Hi @skalle, thanks for the submission!
Would you be able to comment the test output from running these two acceptance tests?
Also would need to update the documentation for the compute_route resource noting that import functionality exists. Thanks!

[skalle]

Hey @grubernaut , thx. for the review.

Sorting out the format and documentation when back to work tomorrow.

[stack72]

Hi @skalle / @grubernaut

Just a FYI, I ran the tests a for this and they pass as expected and made the small formatting changes. I have pushed this to master already

% make testacc TEST=./builtin/providers/google TESTARGS='-run=TestAccComputeRoute'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/04 19:14:53 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccComputeRoute -timeout 120m
=== RUN   TestAccComputeRoute_importBasic
--- PASS: TestAccComputeRoute_importBasic (68.36s)
=== RUN   TestAccComputeRoute_importDefaultInternetGateway
--- PASS: TestAccComputeRoute_importDefaultInternetGateway (89.60s)
=== RUN   TestAccComputeRoute_basic
--- PASS: TestAccComputeRoute_basic (80.55s)
=== RUN   TestAccComputeRoute_defaultInternetGateway
--- PASS: TestAccComputeRoute_defaultInternetGateway (84.01s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/google	322.541s

Thanks

Paul

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.