Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform restarts node when applying default resize_disk value true #14687

Closed
nikoren opened this issue May 19, 2017 · 3 comments
Closed

Terraform restarts node when applying default resize_disk value true #14687

nikoren opened this issue May 19, 2017 · 3 comments

Comments

@nikoren
Copy link

nikoren commented May 19, 2017

Hi, I'm trying to upgrade terraform from 0.7 to 0.9.3 ,
Once I switch to new version terraform identifies that there is no resize_disk value in my current state:

~ digitalocean_droplet.stage-share-xxxx.1
    resize_disk: "" => "true"
  • according to [documentation (https://www.terraform.io/docs/providers/do/r/droplet.html#resize_disk) - this setting controls wether to allow or not disk increase, I couldn't see any possible impact by applying this change.

  • When I try to apply the change , the node is restarted, and in digital_ocean console I can see the following history:

Event	Initiated	Execution	Time
Power On	1 hour ago	6 seconds
Resize	2 hours ago	17 minutes 19 seconds
Power Off	2 hours ago	11 seconds
Create	1 month ago	20 seconds
  • I think terraform tries to go and resize the disk to same size which involves node restart even though no changes were done in configuration.

  • I believe terraform should not restart node and only update state in scenario when actual disk wasn't changed or maybe documentation should be more clear about the fact that node gets restarted when no changes were made to disk configuration.

@andrewsomething
Copy link
Contributor

This looks like an unintended consequence of the change introduced in #13007

@danrabinowitz
Copy link

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants