Don't re-do a ASG on a grace healthcheck grace period change #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested ``` aws_autoscaling_group.rabbit: Modifying... health_check_grace_period: "200" => "3000" aws_autoscaling_group.rabbit: Modifications complete ```
|
Looks perfect to me. An acceptance test would be wonderful but for a change this simple I can understand not having it. Thanks! |
mitchellh
added a commit
that referenced
this pull request
Apr 29, 2015
provider/aws: Don't re-do a ASG on a grace healthcheck grace period change
|
@mitchellh going forward is there a PR with an example acceptance test you can reference if you have one off hand |
|
Take a look at the recently closed provider/aws ones and also just the source itself :) |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if the
health_check_grace_periodis changed it will re-create the ASG. You can do it in the web UI without a reload. This PR allows that to happen.Next run
If I missed something let me know and I'll update the PR.
This PR references #1679