provider/azure: added Azure SQL server and service support. #2380
Conversation
| }, | ||
| "collation": &schema.Schema{ | ||
| Type: schema.TypeString, | ||
| Required: true, |
There was a problem hiding this comment.
This has to be Optional: true since it also has a Default.
There was a problem hiding this comment.
Good catch; also noticed a couple of other discrepancies in the argument definitions and fixed those as well.
|
LGTM. Will wait for some more eyeballs before merging. |
aznashwan
force-pushed
the
f-azure-databases
branch
from
ce44181
to
5c3dd69
Compare
|
@cbednarski Thanks for the review. 😄 |
| * `version` - (Optional) The version of the database server to be used. Can be any | ||
| one of `2.0` or `12.0`. | ||
|
|
||
| * `url` - (Computed) The fully qualified domain name of the databse server. |
|
Two wee docs typos, otherwise this is looking great! |
aznashwan
force-pushed
the
f-azure-databases
branch
from
5c3dd69
to
357ed8e
Compare
|
Fixed. Thanks for the review 😄 |
|
Once again, great work @aznashwan. Incoming! 🚀 |
provider/azure: added Azure SQL server and service support.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Added support, tests and docs for:
Any and all reviews are very much appreciated.