fixed locker not released after workspace removal warning

[likexian]

See: #24019

The locker is not released after workspace removal warning.

[mildwonkey]

Have you considered using a defer() function to take care of this? Several other commands have something this:
defer stateLocker.Unlock(nil)

I don't think it makes a difference in today, but the benefit is that we won't need to add Unlocks before every return which (I think) will help in the future.

[likexian]

Have you considered using a defer() function to take care of this? Several other commands have something this:
defer stateLocker.Unlock(nil)

I don't think it makes a difference in today, but the benefit is that we won't need to add Unlocks before every return which (I think) will help in the future.

My answer is NO.

defer is not suitable for this function, because we have to release the lock before calling delete workspace, see: https://github.com/hashicorp/terraform/blob/master/command/workspace_delete.go#L133

If we add defer stateLocker.Unlock(nil), it works when getting warning, but will do unlock twice when no warning.

[mildwonkey]

Thanks for that @likexian!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.