'terraform -install-autocomplete' fails to respect zsh environment variable 'ZDOTDIR'

[es80]

Terraform Version

Terraform v0.12.29 

Terraform Configuration Files

Debug Output

Crash Output

Expected Behavior

terraform -install-autocomplete for zsh ought to add lines to my .zshrc by finding the location of that file. It assumes the location is ~/.zshrc whereas the location depends on whether the environment variable ZDOTDIR is set.

Actual Behavior

$ terraform -install-autocomplete
Error executing CLI: Did not find any shells to install 

Steps to Reproduce

1. Set ZDOTDIR and move .zshrc accordingly, restart shell and ensure .zshrc has been read OK.
2. terraform -install-autocomplete

Additional Context

Of course it's easy to work around this issue by creating a new file ~/.zshrc, running terraform -install-autocomplete, appending the contents of ~/.zshrc to $ZDOTDIR/.zshrc then deleting ~/.zshrc.

References

[alisdair]

Thanks for reporting this! This is a missing feature in an upstream library we use, posener/complete. There is an existing pull request which I believe would address this, but it needs some support from someone to get it over the line.

[brandondrew]

wow... this should be relatively simple to fix. If I'm not mistaken it's just a matter of looking in the right place, which I believe should be

${ZDOTDIR:-~}/.zshrc

This 👆 defaults to ~ if $ZDOTDIR is not set.