This adds the source_dest_check attribute to the aws_network_interfac… #2741
Conversation
|
This is the same as #2721 but I am happy to close mine as you have added tests :) |
|
@catsby / @phinze / @radeksimko any chance someone could have a look at this - it's a blocker for running a better HA solution for NAT boxes (using ENI and EIPs) thanks :) |
|
bump |
| "source_dest_check": &schema.Schema{ | ||
| Type: schema.TypeBool, | ||
| Optional: true, | ||
| Computed: true, |
There was a problem hiding this comment.
We need to add Default: true, here, or otherwise any user who omits the source_dest_check attribute will send a false value to the API
There was a problem hiding this comment.
which also means that we need to remove the Computed part here (can't have both computed and default)
There was a problem hiding this comment.
Oops! Missed that when I removed the guarding conditional.
|
A few nitpicks but overall looks good! Let's see about the updates and making sure all the Acceptance tests pass, then we'll be good 👍 |
catsby
added
the
waiting-response
…e resource Defaults to true to be consistent with AWS
jszwedko
force-pushed
the
set-source-dest-check-eni
branch
from
68b02dd
to
5554942
Compare
|
@catsby swapped Let me know if any more changes need to be made, thanks for looking at this! |
|
Looking great now, thanks! Pulling this in |
This adds the source_dest_check attribute to the aws_network_interfac…
|
Awesome, thanks! 🎺 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
…e resource
Addresses #2407