Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Unmark provisioner config before validation #27819

Merged
merged 1 commit into from Feb 18, 2021

Conversation

alisdair
Copy link
Member

Sensitive values in provisioner configuration would cause errors in the validate phase. We need to unmark these value before serializing the config value for the provisioner plugin.

Fixes #27763. Also separately fixed on the main branch.

Sensitive values in provisioner configuration would cause errors in the
validate phase. We need to unmark these value before serializing the
config value for the provisioner plugin.
@alisdair alisdair added core v0.14 Issues (primarily bugs) reported against v0.14 releases labels Feb 18, 2021
@alisdair alisdair requested a review from a team February 18, 2021 15:52
@alisdair alisdair self-assigned this Feb 18, 2021
@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #27819 (6fb010f) into v0.14 (74134a8) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
terraform/eval_validate.go 59.14% <100.00%> (+0.25%) ⬆️
terraform/node_resource_plan.go 95.32% <0.00%> (-1.87%) ⬇️
dag/walk.go 91.60% <0.00%> (-0.70%) ⬇️
terraform/evaluate.go 52.89% <0.00%> (-0.42%) ⬇️

@alisdair alisdair merged commit f58c34e into v0.14 Feb 18, 2021
@alisdair alisdair deleted the alisdair/unmark-provisioner-config-014 branch February 18, 2021 16:28
@ghost
Copy link

ghost commented Mar 21, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core v0.14 Issues (primarily bugs) reported against v0.14 releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants