add MapPublicIpOnLaunch

[hden]

fix #263

This option is visible in the subnet status, but only modifiable from another API call.

resource "aws_subnet" "main" {
    vpc_id = "${aws_vpc.main.id}"
    cidr_block = "10.0.1.0/24"
    map_public_ip_on_launch = true
}

Depends on: mitchellh/goamz#95
Related to: #214, #252

[levinotik]

👍

[pearkes]

Great, merging this and going to cc you on the doc additions. Thank you very much!

[pearkes]

@hden Although both these and the goamz changes look fine, I'm getting the following back from Amazon after running the acceptance tests. Did you see this?

* Error modify subnet attributes: The action ModifySubnetAttribute is not valid for this web service. (InvalidAction)

Can you verify the acceptance tests pass for you?

make testacc TEST=github.com/hashicorp/terraform/builtin/providers/aws TESTARGS='-run TestAccAWSSubnet'

[pearkes]

Confusing, as your changes match the documentation entirely. Not sure why this would be the case.

[pearkes]

Okay! See related goamz issue and commit above – we need a higher EC2 API version for this to work. That's a pending pull into goamz, hopefully we can merge that without issue.

[hden]

Thanks @pearkes!