Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering unknown values in map and null string primitives #33029

Merged
merged 4 commits into from
Apr 14, 2023

Conversation

liamcervante
Copy link
Member

This PR fixes 2 issues in the new renderer:

  1. Unknown values are removed from the set of after values by the json plan package for attributes. This affects maps as they are unaware of the values they are supposed to contain. This PR makes the renderer look at the planned unknown values and merge them back into the main after set before computing the diff.
  2. Null strings were being rendered with the %q format which meant they were being encapsulated by quotation marks and the color encodings were being rendered as a string.

This PR fixes both of these issues.

Fixes #33016

Target Release

1.4.6

Draft CHANGELOG entry

BUG FIXES

  • Fix bug when rendering plans that include null strings
  • Fix bug when rendering plans that include unknown values in maps

@liamcervante liamcervante added the 1.4-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Apr 14, 2023
@liamcervante liamcervante merged commit 2c624ac into main Apr 14, 2023
@liamcervante liamcervante deleted the liamcervante/33016 branch April 14, 2023 07:56
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.4-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect rendering of null and unknown in a map(string)
2 participants