Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate unknown and sensitive metadata to dynamic attributes #33057

Merged
merged 2 commits into from Apr 24, 2023

Conversation

liamcervante
Copy link
Member

This PR updates the jsonformat/jsondiff package to include and process the sensitive and computed metadata about the given change.

The package now handles Change objects directly, something that is only possible with the refactor in #33054. This is a good change because now it is actually processing all the information in the change instead of simple subset as it was previously.

The change also moves the logic for processing unknown and sensitive types into the shared structured package so that the differ and the jsondiff package can share the logic.

Fixes #33056

Target Release

1.4.6

Draft CHANGELOG entry

BUG FIXES

  • Fix bug where the sensitive and unknown metadata wasn't being propagated to dynamic attribute types when rendering.

@liamcervante liamcervante requested a review from a team April 20, 2023 12:45
@liamcervante liamcervante marked this pull request as ready for review April 20, 2023 12:53
@liamcervante liamcervante added the 1.4-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Apr 20, 2023
Base automatically changed from liamcervante/sensitive_and_unknown/one to main April 21, 2023 07:52
@liamcervante liamcervante merged commit 519a18a into main Apr 24, 2023
7 checks passed
@liamcervante liamcervante deleted the liamcervante/sensitive_and_unknown/two branch April 24, 2023 08:28
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.4-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

attributes with DynamicPseudoType are not obeying unknown and sensitive metadata when rendered
2 participants