Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add strcontains function and documentation #33069

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Conversation

Cliftonz
Copy link
Contributor

This PR is a continuation of #27518 and #27198 to complete the function for finding a string with in a string.
This new keyword functions as a contains function in terraform to allow users to find strings instead of using the workaround can(regrex(...)).

@hashicorp-cla
Copy link

hashicorp-cla commented Apr 21, 2023

CLA assistant check
All committers have signed the CLA.

@digital-content-events
Copy link

digital-content-events bot commented Apr 21, 2023

📄 Content Checks

Updated: Fri, 21 Apr 2023 15:06:10 GMT

Found 1 error(s)

docs/language/functions/strcontains.mdx

Position Description Rule
1:1-1:1 This file is not present in the nav data file at data/language-nav-data.json. Either add a path that maps to this file in the nav data or remove the file. If you want the page to exist but not be linked in the navigation, add a hidden property to the associated nav node. no-unlinked-pages

@Cliftonz
Copy link
Contributor Author

@kmoe @crw @njuCZ

@kmoe kmoe self-assigned this Apr 21, 2023
@kmoe
Copy link
Member

kmoe commented Apr 21, 2023

Thanks. Please add a description for the function here:

var DescriptionList = map[string]descriptionEntry{

That will fix unit tests.

@Cliftonz
Copy link
Contributor Author

@kmoe @crw following up on this

@crw
Copy link
Collaborator

crw commented Apr 24, 2023

@Cliftonz Thanks, I'll follow up.

@judithpatudith judithpatudith requested a review from a team April 26, 2023 15:38
@crw
Copy link
Collaborator

crw commented Apr 26, 2023

@Cliftonz apologies for the delay - the docs team is going to try to figure out why CI isn't validating your change. Once that validation passes, we'll merge this PR. Thanks for your patience!

@crw
Copy link
Collaborator

crw commented Apr 26, 2023

To be clear, I believe @kmoe will need to merge it. Thanks!

@kmoe kmoe merged commit 3bb6a58 into hashicorp:main Apr 26, 2023
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@crw
Copy link
Collaborator

crw commented Apr 26, 2023

For posterity, please see #33101 for the follow-up PR that fixes the CI/docs issue.

genx7up pushed a commit to aweps/terraform that referenced this pull request Apr 26, 2023
* add strcontains function and documentation
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants