provider/aws: Add CORS settings to S3 bucket

[kjmkznr]

This commit is allows to CORS(Cross-Origin Resource Sharing) rule configuration to S3 bucket resource.

resource "aws_s3_bucket" "b" {
    ....
    cors_rule {
        allowed_headers = ["*"]
        allowed_methods = ["PUT","POST"]
        allowed_origins = ["https://s3-website-test.hashicorp.com"]
        expose_headers = ["ETag"]
        max_age_seconds = 3000
    }
    ....
}

[bizenn]

👍

[2matzzz]

👍

[f440]

👍

[yujideveloper]

👍

[mitto]

👍

[corrupt952]

👍

[catsby]

Can we check for errors here? We've found that setting non-primitives, there can be an error and it's best we inspect/log that

if err := d.Set("cors_rule", rules); err != nil {
  //log
}

[kjmkznr]

Added.

[catsby]

Hey @kjmkznr – so sorry for the delay! I do have a question regarding removing the CORs rules if we remove the website, but other than that this looks great!

Let me know what you think

[kjmkznr]

@catsby
Thanks reviews!

I think, do not need remove CORS rules when website removed.
CORS and website API is independent each other.
We can set CORS rules without website configurations.

[catsby]

Thanks!

[kjmkznr]

@catsby

Thanks!!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.