Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore missing variables during destroy phase #3393

Merged

Conversation

radeksimko
Copy link
Member

This is fixing #2892

I think Mitchell aimed to fix it in https://github.com/hashicorp/terraform/pull/2775/files#diff-6baa6e1e203f1aabf89e2169ec8c89b1R373 but it only covers plan -destroy, not the actual destroy.

I'm not quite sure why there was no walkDestroy operation until now - if there's an obvious reason that I don't see, please tell me.

@phinze
Copy link
Contributor

phinze commented Oct 2, 2015

Thanks for digging into this, @radeksimko!

This looks solid. I talked with @mitchellh about our prior lack of a walkDestroy, and we both agreed that there was no specific reason, and if all the tests pass this seemed okay to do.

Worth noting that previously Destroy: true on the GraphBuilder was used to determine this - I'm guessing we can probably drop that consolidate around operation now that this is landing.

But for now, this LGTM! 🚢

radeksimko added a commit that referenced this pull request Oct 3, 2015
Ignore missing variables during destroy phase
@radeksimko radeksimko merged commit 2106ccf into hashicorp:master Oct 3, 2015
@radeksimko radeksimko deleted the b-destroy-cross-providers branch October 3, 2015 21:24
@ghost
Copy link

ghost commented Apr 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants