terraform fmt: add .tfmock.hcl as a supported file extension

[HenriBlacksmith]

Fixes #34577

[hashicorp-cla]

All committers have signed the CLA.

[HenriBlacksmith]

@liamcervante the suggested fix for #34577 is ready to be reviewed.

I added some test cases using mock AWS data sources and resources (I saw many already in the tests)

[liamcervante]

Hi @HenriBlacksmith, the implementation and the new test cases look fine to me. Thanks so much for putting this together.

I just noticed, however, that the new test cases aren't actually executing. If you look at the test file you can see it's only checking things with the .tftest.hcl extension specifically: https://github.com/hashicorp/terraform/blob/main/internal/command/fmt_test.go#L20-L22

I didn't notice this before, so I can take full responsibility for it being missed here. But, could you copy the existing test case TestFmt_TestFiles, make a new one based on it called TestFmt_MockDataFiles or something similar, and then copy your new test files into a new directory tfmock-fmt or something similar, and then update the new test case to read the correct directory, and file extensions.

Hopefully that makes sense! Thanks again!

[HenriBlacksmith]

Hi @HenriBlacksmith, the implementation and the new test cases look fine to me. Thanks so much for putting this together.

I just noticed, however, that the new test cases aren't actually executing. If you look at the test file you can see it's only checking things with the .tftest.hcl extension specifically: https://github.com/hashicorp/terraform/blob/main/internal/command/fmt_test.go#L20-L22

I didn't notice this before, so I can take full responsibility for it being missed here. But, could you copy the existing test case TestFmt_TestFiles, make a new one based on it called TestFmt_MockDataFiles or something similar, and then copy your new test files into a new directory tfmock-fmt or something similar, and then update the new test case to read the correct directory, and file extensions.

Hopefully that makes sense! Thanks again!

Sure, will have a look at this and fix asap, thanks for checking this (I should have checked test results carefully)

[HenriBlacksmith]

@liamcervante I added the new test case dedicated to .tfmock.hcl files, it should be better now (The test data changed a bit now that the formatter actually runs on them 😸 )

[liamcervante]

LGTM! We will backport this into v1.7, so it should be released within 1.7.2. Thanks for your contribution!

[github-actions]

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.