command: Add terraform untaint
#5527
Conversation
|
Want to fill in a few more unit tests for |
| var allowMissing bool | ||
| var module string | ||
| var index int | ||
| cmdFlags := c.Meta.flagSet("taint") |
There was a problem hiding this comment.
Shouldn't the flag set name be untaint? I guess it's just typo.
phinze
changed the title
terraform untaintterraform untaint
|
Thanks for the review, @radeksimko - addressed the typos you caught and added the state unit tests I mentioned. PTAL when you have a moment! |
phinze
force-pushed
the
phinze/untaint
branch
2 times, most recently
from
7585ded
to
5b6ca9e
Compare
|
@radeksimko ping 😀 |
|
@phinze just looking at this... I first had to look up |
| "github.com/mitchellh/cli" | ||
| ) | ||
|
|
||
| func TestUntaint(t *testing.T) { |
There was a problem hiding this comment.
Just a nitpick, but as this is testing a noop case, can we also name it that way, so it's obvious?
There was a problem hiding this comment.
I don't think this is a noop - it's the "basic" use case - test_instance.foo starts tainted and ends up untainted.
There was a problem hiding this comment.
d'oh, obviously, sorry, you're right!
|
Other than the test naming nitpick and |
- [x] Docs - [x] Command Unit Tests - [x] State Unit Tests Closes #4820
|
This LGTM now. Feel free to merge. |
command: Add `terraform untaint`
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Closes #4820