Add functionality to specify and mount bootable vmdk #6146
Conversation
| @@ -268,6 +270,14 @@ func resourceVSphereVirtualMachine() *schema.Resource { | |||
| Optional: true, | |||
| ForceNew: true, | |||
| }, | |||
|
|
|||
| "bootable_vmdk_path": &schema.Schema{ | |||
| // TODO: Add ValidateFunc to check if path exists | |||
There was a problem hiding this comment.
How critical is this??
There was a problem hiding this comment.
I figure its a 'good to have' but not a blocker for my first stab. There aren't checks for things like network label / folder / datacenter / ect, which we could do, but just aren't at the yet. I figure its a low hanging fruit to call out.
|
@dkalleg first off thanks for your help!!! You want to email me at clove at consulting dot net? I can provide a bit of guidance. |
|
Geeze type your email correctly ... clove |
|
@kristinn I'd appreciate hearing any feedback you had regarding this PR since tkak and phinze are so busy. |
| } else { | ||
| return fmt.Errorf("Size argument is required.") | ||
| return fmt.Errorf("Size or bootable_vmdk_path argument is required.") |
There was a problem hiding this comment.
Perhaps create an anonymous function for this and get rid of the code duplication.
|
@dkalleg Looks very good, had just two comments. 👍 |
User may specify a vmdk in their disk definition. The options size, template, and vmdk are considered to be mutually exclusive. User may also set whether each disk associated with the vm should try to boot after creation. Todo: Enforce mutual exclusivity, validate the bootable_vmdk_path
|
@chrislovecnm @kristinn @phinze @tkak Made some adjustments to make this a little more versatile/generic. Instead of focusing on just bootable vmdks this is now focusing on mounting any existing vmdk with the option of specifying a disk as |
| @@ -455,6 +455,68 @@ func TestAccVSphereVirtualMachine_createWithCdrom(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestAccVSphereVirtualMachine_createWithExistingVmdk(t *testing.T) { | |||
There was a problem hiding this comment.
I do love it when I see all of the plus signs that add a unit test. Cookie for u!!!
|
@stack72 - Paul you ROCK!! |
User may specify a vmdk in their disk definition. The options size, template, and vmdk are considered to be mutually exclusive. User may also set whether each disk associated with the vm should try to boot after creation. Todo: Enforce mutual exclusivity, validate the bootable_vmdk_path
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
User may specify a bootable_vmdk_path in their disk definition. This assumes that a bootable vmdk is uploaded to an accessible datastore in vSphere. This does not copy the vmdk prior to starting the vm to preserve state; this, however could be a future enhancement.
The options size, template, and bootable_vmdk_path are considered to be mutually exclusive.
Todo: Enforce mutual exclusivity, validate the bootable_vmdk_path