Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: guard against missing image_digest #7966

Merged
merged 1 commit into from Aug 4, 2016
Merged

provider/aws: guard against missing image_digest #7966

merged 1 commit into from Aug 4, 2016

Conversation

nicolai86
Copy link
Contributor

This PR fixes #7956.

AWS does not add an explicit :latest when no digest is given, which leads to a crash for setups like this.

resource "aws_ecs_task_definition" "mongo" {
  family = "mongodb"
  container_definitions = <<DEFINITION
[
  {
    "cpu": 128,
    "environment": [{
      "name": "SECRET",
      "value": "KEY"
    }],
    "essential": true,
    "image": "mongo",
    "memory": 128,
    "name": "mongodb"
  }
]
DEFINITION
}

This PR fixes this issue.

@stack72
Copy link
Contributor

stack72 commented Aug 4, 2016

Hi @nicolai86

Thanks so much fro the bug fix here :)

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSEcsDataSource_ecsContainerDefinition'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEcsDataSource_ecsContainerDefinition -timeout 120m
=== RUN   TestAccAWSEcsDataSource_ecsContainerDefinition
--- PASS: TestAccAWSEcsDataSource_ecsContainerDefinition (123.78s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    123.796s

@stack72 stack72 merged commit 582e3bd into hashicorp:master Aug 4, 2016
@ghost
Copy link

ghost commented Apr 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@hashicorp hashicorp locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform 0.7 crash using aws_ecs_container_definition
2 participants