Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vSphere provider: diskpaths format not valid for datastore in datastore cluster #8059

Closed
dagnello opened this issue Aug 8, 2016 · 3 comments
Labels
bug provider/vsphere waiting-response An issue/pull request is waiting for a response from the community

Comments

@dagnello
Copy link
Contributor

dagnello commented Aug 8, 2016

virtual_disk and virtual_machine resources, make use of Sprintf to compile vmdk/iso paths:
diskPath := fmt.Sprintf("[%v] %v", vDisk.datastore, vDisk.vmdkPath)

These paths should be compile with the finder.Datastore object instead, e.g:
ds, err := getDatastore(finder, "myDataStore")
dsPath := ds.Path(pathInDatastore)

@chrislovecnm
Copy link
Contributor

please put in a PR if you are able to!

@stack72
Copy link
Contributor

stack72 commented Aug 18, 2016

@dagnello I believe this can be closed via #8075

Correct?

@stack72 stack72 added the waiting-response An issue/pull request is waiting for a response from the community label Aug 18, 2016
@dagnello dagnello closed this as completed Sep 1, 2016
@ghost
Copy link

ghost commented Apr 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug provider/vsphere waiting-response An issue/pull request is waiting for a response from the community
Projects
None yet
Development

No branches or pull requests

3 participants