Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting datacenter when using consul remote state #8102

Merged
merged 2 commits into from
Aug 11, 2016
Merged

Support setting datacenter when using consul remote state #8102

merged 2 commits into from
Aug 11, 2016

Conversation

bodiug
Copy link
Contributor

@bodiug bodiug commented Aug 10, 2016

Small change to allow setting datacenter when using consul remote state:

terraform remote config -backend=consul -backend-config=path=some/path -backend-config=access_token=some-token -backend-config=datacenter=dc1

This fixes #1614.

Change-Id: I8c03f4058e9373f0de8fde7ce291ec552321cc60
@bodiug bodiug changed the title Support setting datacenter when using consul remote state #1614 Support setting datacenter when using consul remote state Aug 10, 2016
@stack72
Copy link
Contributor

stack72 commented Aug 11, 2016

Hi @guidob

The tests pass as expected here. Please could you add some documentation for this as part of the PR?

% make testacc TEST=./builtin/providers/consul TESTARGS='-run='                                                                                                                                         1 ↵
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/11 20:39:44 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/consul -v -run= -timeout 120m
=== RUN   TestAccDataConsulKeys_basic
--- PASS: TestAccDataConsulKeys_basic (0.03s)
=== RUN   TestAccConsulAgentService_basic
--- PASS: TestAccConsulAgentService_basic (0.02s)
=== RUN   TestAccConsulCatalogEntry_basic
--- PASS: TestAccConsulCatalogEntry_basic (0.03s)
=== RUN   TestAccConsulKeyPrefix_basic
--- PASS: TestAccConsulKeyPrefix_basic (0.09s)
=== RUN   TestConsulKeysMigrateState
--- PASS: TestConsulKeysMigrateState (0.00s)
=== RUN   TestConsulKeysMigrateState_empty
--- PASS: TestConsulKeysMigrateState_empty (0.00s)
=== RUN   TestAccConsulKeys_basic
--- PASS: TestAccConsulKeys_basic (0.07s)
=== RUN   TestAccConsulNode_basic
--- PASS: TestAccConsulNode_basic (0.02s)
=== RUN   TestAccConsulService_basic
--- PASS: TestAccConsulService_basic (0.03s)
=== RUN   TestResourceProvider
--- PASS: TestResourceProvider (0.00s)
=== RUN   TestResourceProvider_impl
--- PASS: TestResourceProvider_impl (0.00s)
=== RUN   TestResourceProvider_Configure
--- PASS: TestResourceProvider_Configure (0.00s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/consul 0.304s

Thanks

Paul

@stack72 stack72 added enhancement waiting-response An issue/pull request is waiting for a response from the community backend/consul labels Aug 11, 2016
Change-Id: Ia62feea7a910a76308f0a5e7f9505c9a210e0339
@bodiug
Copy link
Contributor Author

bodiug commented Aug 11, 2016

@stack72 ,

Good point, first time for me. Added a small piece.

@stack72
Copy link
Contributor

stack72 commented Aug 11, 2016

@guidob thanks for getting back to me so fast on this :) This LGTM so will merge when the build goes green!

Thanks for the work on this

@stack72 stack72 merged commit ee9ebe8 into hashicorp:master Aug 11, 2016
@ghost
Copy link

ghost commented Apr 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend/consul enhancement waiting-response An issue/pull request is waiting for a response from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consul remote state backend to support setting a datacenter
2 participants