provider/aws: Allow aws_alb to have the name auto-generated

[stack72]

In order to satisify scenarios where a lifecycle is block is used, we
would need the AWS ALB name field to be autogenerated. We follow the
same work as AWS ELB, we allow either a name-prefix or we automatically assign a prefix of tf-lb

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSALB_'                                                                                                                            2 ↵ ✹
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/09/08 12:43:40 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSALB_ -timeout 120m
=== RUN   TestAccAWSALB_basic
--- PASS: TestAccAWSALB_basic (79.81s)
=== RUN   TestAccAWSALB_generatedName
--- PASS: TestAccAWSALB_generatedName (93.81s)
=== RUN   TestAccAWSALB_namePrefix
--- PASS: TestAccAWSALB_namePrefix (73.48s)
=== RUN   TestAccAWSALB_tags
--- PASS: TestAccAWSALB_tags (181.32s)
=== RUN   TestAccAWSALB_noSecurityGroup
--- PASS: TestAccAWSALB_noSecurityGroup (66.03s)
=== RUN   TestAccAWSALB_accesslogs
--- PASS: TestAccAWSALB_accesslogs (130.82s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    625.285s

[catsby]

LGTM – should probably add name_prefix in there while we're at it

[stack72]

@catsby added :)

[radeksimko]

It is basically working, but the + quantifier at the end doesn't make much sense as it belongs to b.
I assume "^tf-lb.+" is what you intended to type here? Perhaps "^tf-lb" would be sufficient and less greedy.

[stack72]

Hi @radeksimko

I have made the change as requested - the new test results:

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSALB_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/09/12 10:32:12 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSALB_ -timeout 120m
=== RUN   TestAccAWSALB_basic
--- PASS: TestAccAWSALB_basic (65.21s)
=== RUN   TestAccAWSALB_generatedName
--- PASS: TestAccAWSALB_generatedName (64.01s)
=== RUN   TestAccAWSALB_namePrefix
--- PASS: TestAccAWSALB_namePrefix (66.22s)
=== RUN   TestAccAWSALB_tags
--- PASS: TestAccAWSALB_tags (98.58s)
=== RUN   TestAccAWSALB_noSecurityGroup
--- PASS: TestAccAWSALB_noSecurityGroup (59.35s)
=== RUN   TestAccAWSALB_accesslogs
--- PASS: TestAccAWSALB_accesslogs (118.57s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    471.966s

[levinse]

@stack72 thanks for making the change to allow name to be optional so create_before_destroy can be used.

Unfortunately this is still not usable. Using name_prefix and create_before_destroy makes the auto-generated name (including the prefix) over 32 chars, which results in an error from Terraform.

Can you guys cut the length of the auto-generated portion in half so name_prefix can be used? Or better yet, adjust the length of the auto-generated name based on the length of name_prefix so the final name is under 32 chars?

[stack72]

Hi @levinse

Can you post what you autogenerated name is? When i don't specify a name i definitely have less than 32 characters

P.

[levinse]

@stack72 I don't have access to the test environment now but if you use name_prefix of e.g. 10 chars the full string with the prefix was over 40 chars. I'll try to post the specifics later but it should be easy to repro.

[levinse]

Hi @stack72 any updates on this? Thanks

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.