AWS: Skip DetachVolume if volume is not attached #9023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catsby
suggested changes
Sep 28, 2016
| return fmt.Errorf("Error reading EC2 volume %s: %s", vID, desc_err) | ||
| } | ||
|
|
||
| if *attr.Volumes[0].State == "available" { |
There was a problem hiding this comment.
can we put a guard here to protect us from the off chance that attr.Volumes is nil?
There was a problem hiding this comment.
catsby
added
the
waiting-response
Jonnymcc
force-pushed
the
destroying-detached-vol-attch-res
branch
from
cb79323
to
dc4a7b7
Compare
|
Thanks! |
catsby
approved these changes
Oct 3, 2016
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I manually terminated an instance thus putting the EBS volume in an "available" state. When running
terraform applyI got this error...This change appears to have fixed the problem. I ran
terraform applyand the aws_volume_attachment resource was deleted as expected.