Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New AWS resource ssm_activation #9111

Merged
merged 1 commit into from
Oct 28, 2016
Merged

New AWS resource ssm_activation #9111

merged 1 commit into from
Oct 28, 2016

Conversation

liamjbennett
Copy link
Contributor

Adding a new resource to support activation of managed instances for
on-premise virtual-machines.

Last of the resources to close off #4952

@liamjbennett
Copy link
Contributor Author

This is currently blocked by an issue that needs some deeper investigation. At the moment the tests are receiving the error:
[ERROR] Error creating SSM activation: ValidationException: Not existing role: arn:aws:iam::483560084512:role/AROAJVG36BCT2PT2QMVOW

I have been able to re-create this error manually in the console by creating an activation using a custom role with an incorrect assume role policy however it is unclear why this test is failing.

@liamjbennett
Copy link
Contributor Author

Debugging this I have discovered that there is an issue related specifying the region. When running similar commands via the cli the --region flag needs to be specified if not reading from the environment. In addition it appears from debugging the console that region is specified as part of the request.

I am unclear at this stage if this is an issue with my implementation or with the sdk

Adding a new resource to support activation of managed instances for
on-premise virtual-machines.
@liamjbennett
Copy link
Contributor Author

➜  terraform git:(ssm_activation) ✗ TF_LOG=TRACE TF_LOG_PATH=test.log make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSSMActivation_basic'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/10/28 09:59:37 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSSMActivation_basic -timeout 120m
=== RUN   TestAccAWSSSMActivation_basic
--- PASS: TestAccAWSSSMActivation_basic (23.18s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    23.188s

@liamjbennett liamjbennett changed the title [WIP] New AWS resource ssm_activation New AWS resource ssm_activation Oct 28, 2016
@stack72
Copy link
Contributor

stack72 commented Oct 28, 2016

LGTM! Thanks @liamjbennett :)

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSSMActivation_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/10/28 11:57:05 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSSMActivation_ -timeout 120m
=== RUN   TestAccAWSSSMActivation_basic
--- PASS: TestAccAWSSSMActivation_basic (39.60s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    39.620s

@stack72 stack72 merged commit 8fee764 into hashicorp:master Oct 28, 2016
mathieuherbert pushed a commit to mathieuherbert/terraform that referenced this pull request Oct 30, 2016
Adding a new resource to support activation of managed instances for
on-premise virtual-machines.
gusmat pushed a commit to gusmat/terraform that referenced this pull request Dec 6, 2016
Adding a new resource to support activation of managed instances for
on-premise virtual-machines.
@ghost
Copy link

ghost commented Apr 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants