Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make secret input secret #188

Merged
merged 3 commits into from
Sep 13, 2022
Merged

Make secret input secret #188

merged 3 commits into from
Sep 13, 2022

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Sep 9, 2022

This (in part) resolves hashicorp/vagrant#12865. This enables the ui to be able to accept secret interactive input. For example, now when mounting SMB folders:

default: You will be asked for the username and password to usefor the SMB
default: folders shortly. Please use the proper username/password of your
default: account.
default:  
default: Username (user[@domain]): myusername
default: Password (will be hidden):   
  ==> default: Clearing any previously set network interfaces...

terminal/glint.go Outdated Show resolved Hide resolved
@soapy1 soapy1 changed the title Make secert input secret Make secret input secret Sep 12, 2022
Copy link
Member

@chrisroberts chrisroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soapy1 soapy1 merged commit 67d5ab4 into main Sep 13, 2022
@soapy1 soapy1 deleted the secret-input branch September 13, 2022 20:15
@soapy1 soapy1 mentioned this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support secret interactive input
2 participants