vagrant destroy kills too many interfaces #1324

rottenbytes · 2013-01-17T09:22:03Z

When working on a multi users environment, each with its vagrant setup (and vboxnet interface, for network isolation, routing) vagrant kills too many interfaces on destroy

sample ifconfig output before:

[snip]

lo        Link encap:Local Loopback··
          inet addr:127.0.0.1  Mask:255.0.0.0
          inet6 addr: ::1/128 Scope:Host
          UP LOOPBACK RUNNING  MTU:16436  Metric:1
          RX packets:125499 errors:0 dropped:0 overruns:0 frame:0
          TX packets:125499 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:0·
          RX bytes:11811259 (11.2 MiB)  TX bytes:11811259 (11.2 MiB)

vboxnet0  Link encap:Ethernet  HWaddr 0a:00:27:00:00:00··
          inet addr:10.231.40.1  Bcast:10.231.40.255  Mask:255.255.255.0
          inet6 addr: fe80::800:27ff:fe00:0/64 Scope:Link
          UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
          RX packets:0 errors:0 dropped:0 overruns:0 frame:0
          TX packets:13 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:1000·
          RX bytes:0 (0.0 B)  TX bytes:978 (978.0 B)

vboxnet1  Link encap:Ethernet  HWaddr 0a:00:27:00:00:01··
          inet addr:10.231.42.1  Bcast:10.231.42.255  Mask:255.255.255.0
          inet6 addr: fe80::800:27ff:fe00:1/64 Scope:Link
          UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
          RX packets:0 errors:0 dropped:0 overruns:0 frame:0
          TX packets:333 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:1000·
          RX bytes:0 (0.0 B)  TX bytes:15282 (14.9 KiB)

vboxnet2  Link encap:Ethernet  HWaddr 0a:00:27:00:00:02··
          inet addr:10.231.41.1  Bcast:10.231.41.255  Mask:255.255.255.0
          inet6 addr: fe80::800:27ff:fe00:2/64 Scope:Link
          UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
          RX packets:0 errors:0 dropped:0 overruns:0 frame:0
          TX packets:4240 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:1000·
          RX bytes:0 (0.0 B)  TX bytes:186252 (181.8 KiB)

then "vagrant destroy aVM"

sample output after :

[snip]

lo        Link encap:Local Loopback··
          inet addr:127.0.0.1  Mask:255.0.0.0
          inet6 addr: ::1/128 Scope:Host
          UP LOOPBACK RUNNING  MTU:16436  Metric:1
          RX packets:125499 errors:0 dropped:0 overruns:0 frame:0
          TX packets:125499 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:0·
          RX bytes:11811259 (11.2 MiB)  TX bytes:11811259 (11.2 MiB)

vboxnet2  Link encap:Ethernet  HWaddr 0a:00:27:00:00:02··
          inet addr:10.231.41.1  Bcast:10.231.41.255  Mask:255.255.255.0
          inet6 addr: fe80::800:27ff:fe00:2/64 Scope:Link
          UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
          RX packets:0 errors:0 dropped:0 overruns:0 frame:0
          TX packets:4240 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:1000·
          RX bytes:0 (0.0 B)  TX bytes:186252 (181.8 KiB)

and if the user with VMs linked to vboxnet2 destroys a VM, then vboxneti0 and vboxnet1 get destroyed. The vms do not get killed or harmed, but they lose the network.

Each VM has 2 interfaces, 1st one is using vbox DHCP, and the second one is a hostonly one (used in routing)
sample VagrantFile entry

config.vm.define :trash1 do |trash1_config|
  trash1_config.vm.forward_port(22,14026)
  trash1_config.vm.host_name = "trash1.sandboxnico.loc"
  trash1_config.vm.network :hostonly, "10.231.40.6"
  trash1_config.vm.provision :shell, :path => "bootstrap_managed.sh"
  trash1_config.vm.customize ["modifyvm", :id, "--memory", 256]
end

My guess is that the code in the function "delete_unused_host_only_networks" (plugins/providers/virtualbox/driver/version_4_2.rb:67) is not aware of the multi users aspect of the usage, then kills interfaces that seem unused to it.

additionnal informations :

Vagrant version : 1.0.6 (same in 1.0.5)
Virtualbox version : 4.2
OS : Debian squeeze

The text was updated successfully, but these errors were encountered:

mitchellh · 2013-01-29T19:12:51Z

You're correct. I detect unused network interfaces by inspecting all VMs that VirtualBox knows about. This does not include (rightfully) other user's virtual machines.

Do you have an idea of how to better do this check? I'm investigating but nothing jumps out to me yet.

rottenbytes · 2013-01-30T09:07:50Z

As you can't see other users VMs with "VBoxManage list " it seems that the solution is going to be hard to find.

I see 2 options :

add a flag (or config option) in vagrant to disable that cleanup. This could also be done at confirmation on the destroy dialog.
remove the cleanup (probably not wanted)

eedgar · 2013-01-30T15:00:54Z

How about you record in the file which ones vagrant created via comments in
the files? Then cleanup those based on the comments?

On Wed, Jan 30, 2013 at 3:07 AM, Nicolas Szalay notifications@github.comwrote:

As you can't see other users VMs with "VBoxManage list " it seems that the
solution is going to be hard to find.

I see 2 options :

add a flag (or config option) in vagrant to disable that cleanup

remove the cleanup (probably not wanted)

—
Reply to this email directly or view it on GitHubhttps://github.com/vagrant destroy kills too many interfaces #1324#issuecomment-12880345.

rottenbytes · 2013-01-30T15:06:54Z

It was an option we talked about with my colleagues, but if the interface gets reused by vbox for another user he will be stuck.

marsmensch · 2013-01-30T15:29:22Z

Tough challenge..... i looked through all modifyvm parameters but found none to be suited for the cause.
Given that this is a corner case i would also prefer to have a flag (or config option) in vagrant to disable that cleanup.

mitchellh · 2013-01-30T16:08:59Z

I'm actually running into this same challenge with the VMware Fusion provider that I have been working on. Fusion provides no central way to do this same thing. With Fusion I decided to just punt on the issue and just put up a "known issues" page that covers this limitation.

Perhaps I should just do the same with VirtualBox.

mitchellh · 2013-07-18T04:11:34Z

Coming back to this finally. So, the VMware provider, used by thousands of people, doesn't clean up network interfaces. It never has. And nobody has complained. Maybe the solution to this is to just actually disable that code path...

rottenbytes · 2013-07-18T05:19:46Z

Agreed 👍

omribahumi · 2013-07-18T19:29:21Z

Here's how I patched my Vagrantfile to disable this behaviour on Virtualbox:

[VagrantPlugins::ProviderVirtualBox::Driver::Version_4_1, VagrantPlugins::ProviderVirtualBox::Driver::Version_4_2].each do |cls|
  cls.class_eval do
    def delete_unused_host_only_networks
      puts "delete_unused_host_only_networks discarded"
    end
  end
end

mitchellh · 2013-07-23T22:37:44Z

Vagrant no longer removes unused network interfaces and leaves it up to the user. This can forcibly be re-enabled using VirtualBox provider-specific config:

config.vm.provider "virtualbox" do |v|
  v.destroy_unused_network_interfaces = true
end

tknerr · 2013-07-26T20:03:03Z

cool stuff - that was always annoying on windows... 👍

jameshilliard · 2013-11-13T09:14:09Z

I think this is being handled wrong still for private networks. If no IP is specified vagrant should first attempt to match the guest static IP to any existing host-only adapters before generating a new one, otherwise multiple adapters end up being generated, at a minimum there should be an option for this. It should also have the ability to disable/reconfigure dhcp for that network if needed as opposed to just generating more adapters. Generating more than 1 host-only adapter should really be a last resort used if its impossible to use/reconfigure existing ones.

richard-scott · 2016-04-12T14:45:06Z

I have noticed that Vagrant may not remove "vboxnet0" anymore, but it does shut down the interface, and remove its IP making it useless still ;-(

AndyBruce mentioned this issue Feb 7, 2013

vagrant destroy deletes all host only networks no matter what #1347

Closed

mitchellh mentioned this issue Jul 19, 2013

Make destroying and recreating of hostonly adapter optional #1733

Closed

mitchellh added a commit that referenced this issue Jul 23, 2013

VirtualBox no longer removes network interfaces [GH-1324]

b2ee015

mitchellh closed this as completed Jul 23, 2013

dldinternet pushed a commit to dldinternet/vagrant that referenced this issue Aug 26, 2013

VirtualBox no longer removes network interfaces [hashicorpGH-1324]

0c08096

dldinternet pushed a commit to dldinternet/vagrant that referenced this issue Sep 1, 2013

VirtualBox no longer removes network interfaces [hashicorpGH-1324]

a8c6135

hashicorp locked and limited conversation to collaborators Apr 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vagrant destroy kills too many interfaces #1324

vagrant destroy kills too many interfaces #1324

rottenbytes commented Jan 17, 2013

mitchellh commented Jan 29, 2013

rottenbytes commented Jan 30, 2013

eedgar commented Jan 30, 2013

rottenbytes commented Jan 30, 2013

marsmensch commented Jan 30, 2013

mitchellh commented Jan 30, 2013

mitchellh commented Jul 18, 2013

rottenbytes commented Jul 18, 2013

omribahumi commented Jul 18, 2013

mitchellh commented Jul 23, 2013

tknerr commented Jul 26, 2013

jameshilliard commented Nov 13, 2013

richard-scott commented Apr 12, 2016

vagrant destroy kills too many interfaces #1324

vagrant destroy kills too many interfaces #1324

Comments

rottenbytes commented Jan 17, 2013

mitchellh commented Jan 29, 2013

rottenbytes commented Jan 30, 2013

eedgar commented Jan 30, 2013

rottenbytes commented Jan 30, 2013

marsmensch commented Jan 30, 2013

mitchellh commented Jan 30, 2013

mitchellh commented Jul 18, 2013

rottenbytes commented Jul 18, 2013

omribahumi commented Jul 18, 2013

mitchellh commented Jul 23, 2013

tknerr commented Jul 26, 2013

jameshilliard commented Nov 13, 2013

richard-scott commented Apr 12, 2016