Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh -c output is polluted with CR chars #6827

Closed
ntki opened this issue Jan 8, 2016 · 3 comments · Fixed by #8643
Closed

ssh -c output is polluted with CR chars #6827

ntki opened this issue Jan 8, 2016 · 3 comments · Fixed by #8643
Assignees
@briancain
Labels
bug confirmed core
Milestone
2.0

Comments

@ntki
Copy link

ntki commented Jan 8, 2016

Version: only tried 1.7.4 and 1.8.1.

I was trying to pipe out binary from a linux vm with ssh on a linux host. With option -c it seems to prepend every \n with an \r. Fortunately it is not the case with --.

$ vagrant ssh -- "echo test" | xxd
0000000: 7465 7374 0a                             test.

$ vagrant ssh -c "echo test" | xxd
Connection to 127.0.0.1 closed.
0000000: 7465 7374 0d0a                           test..
@chrisroberts chrisroberts added this to the 1.8 milestone Oct 3, 2016
@chrisroberts
Copy link
Member

Hi there,

Thanks for reporting this bug. I'm sure this was a real issue when originally reported (our fault for not looking sooner!) but there have been multiple Vagrant releases since the original report. I'm going to close this issue now and request you reopen the issue if you're still experiencing this problem. I'm sorry this wasn't looked at earlier ☹️

Cheers!

@ntki
Copy link
Author

ntki commented Dec 12, 2016 •
edited

Hi

Just tried it with 1.9.0 and 1.9.1. The issue is still standing.

Cheers

ps.: @chrisroberts: it seems that I cannot reopen this ticket.

@chrisroberts chrisroberts reopened this Dec 13, 2016
briancain added a commit to briancain/vagrant that referenced this issue Jun 3, 2017
@briancain
(hashicorp#6827) Introduce tty flag for ssh command execution
98944b9 
Prior to this commit, if a user ran the `vagrant ssh -c CMD` command, it
would not allow the user to configure pseudo-terminal allocation. This
commit introduces a -t flag for the `vagrant ssh` command which defaults
to true if not specified.
briancain added a commit to briancain/vagrant that referenced this issue Jun 3, 2017
@briancain
(hashicorp#6827) Introduce tty flag for ssh command execution
7ffb2c8 
Prior to this commit, if a user ran the `vagrant ssh -c CMD` command, it
would not allow the user to configure pseudo-terminal allocation. This
commit introduces a -t flag for the `vagrant ssh` command which defaults
to true if not specified.
briancain added a commit to briancain/vagrant that referenced this issue Jun 3, 2017
@briancain
(hashicorp#6827) Introduce tty flag for ssh command execution
8370a9b 
Prior to this commit, if a user ran the `vagrant ssh -c CMD` command, it
would not allow the user to configure pseudo-terminal allocation. This
commit introduces a -t flag for the `vagrant ssh` command which defaults
to true if not specified.
briancain added a commit to briancain/vagrant that referenced this issue Jun 3, 2017
@briancain
(hashicorp#6827) Introduce tty flag for ssh command execution
2af1ec5 
Prior to this commit, if a user ran the `vagrant ssh -c CMD` command, it
would not allow the user to configure pseudo-terminal allocation. This
commit introduces a -t flag for the `vagrant ssh` command which defaults
to true if not specified.
briancain added a commit to briancain/vagrant that referenced this issue Jun 3, 2017
@briancain
(hashicorp#6827) Introduce tty flag for ssh command execution
30d2f3d 
Prior to this commit, if a user ran the `vagrant ssh -c CMD` command, it
would not allow the user to configure pseudo-terminal allocation. This
commit introduces a -t flag for the `vagrant ssh` command which defaults
to true if not specified.
briancain added a commit to briancain/vagrant that referenced this issue Jun 3, 2017
@briancain
(hashicorp#6827) Introduce tty flag for ssh command execution
1ade699 
Prior to this commit, if a user ran the `vagrant ssh -c CMD` command, it
would not allow the user to configure pseudo-terminal allocation. This
commit introduces a -t flag for the `vagrant ssh` command which defaults
to true if not specified.
@briancain briancain mentioned this issue Jun 5, 2017
Merged
gitebra pushed a commit to gitebra/vagrant that referenced this issue Jun 8, 2017
@jojohans
Merge commit '378aae878252a9d5a008f6df485de116eacdc2f1'
9e9bec8 
* commit '378aae878252a9d5a008f6df485de116eacdc2f1':
  (hashicorp#7188) Clean up vagrant snapshot restore/delete error messages
  Add basic unit test for CWD change warning
  Tests regarding warning whenever CWD changes
  Warn about changes to CWD on every machine action
  (hashicorp#6827) Introduce tty flag for ssh command execution
  Fixes typo in broken link to documentation
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@hashicorp hashicorp locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@briancain briancain

Labels
bug confirmed core
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Introduce tty flag for ssh command execution briancain/vagrant
4 participants
@chrisroberts @sethvargo @briancain @ntki