Ensure proper paths are shown in config loading exceptions #11056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for windows Prior to this commit, vagrant was not grabbing all of the tokens on Windows for showing the full drive because the ruby api for it behaves differenly on windows compared to other platforms. This commit changes that by ensuring the letter drive is attached to the path when showing an exception.
…ions Prior to this commit, if there was a config error inside a provider block, Vagrant wouldn't grab the right backtrace token on windows since the api is different for ruby on Windows compared to all other platforms. This commit ensures that the proper line number is chosen so the error message is correct.
chrisroberts
approved these changes
Sep 12, 2019
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes up some issues on Windows where Vagrant was not grabbing the proper path for Windows hosts when an exception occurred loading a config file.
Fixes #10924, Fixes #11022