Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing #1088 - Adding puppet file configuration to copy index.html file ... #1115

Closed
wants to merge 2 commits into from

Conversation

ryanneufeld
Copy link

Adding puppet file configuration to copy index.html file to the correct location.

@ryanneufeld
Copy link
Author

Mergey mergey?

@mitchellh
Copy link
Contributor

Hm. I think instead of this I'd prefer if the entire "/vagrant" directory was a document root. Perhaps the cleanest way to do this would be an augeas rule but I'm not sure if augeas is installed by default in the VMs. Thoughts?

At the very least, maybe make this a symlink to "/vagrant/index.html" so that people following the guide can create it after the fact.

@ryanneufeld
Copy link
Author

I don't think augeas is installed by default, and it would mean some extra modules for puppet as well. As far as a quick start guide is concerned I think that would be not-quick.

Perhaps a symlink of /var/www to /vagrant (or /vagrant/www) would be a better option?

@ryanneufeld
Copy link
Author

@mitchellh We're hoping to depend on this doc for next weeks jQuery summit. Is there any chance you can merge this PR, and I'll come up with a better option for you later on?

@hashicorp hashicorp locked and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants