Docker provider: catch container name when using podman. #11356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
LGTM. |
|
Note: this is using |
pvalena
previously approved these changes
Feb 11, 2020
jackorp
force-pushed
the
vagrant-podman-container-build
branch
2 times, most recently
from
577475f
to
a170709
Compare
pvalena
previously approved these changes
Feb 12, 2020
jackorp
force-pushed
the
vagrant-podman-container-build
branch
2 times, most recently
from
7adf7b6
to
eb30324
Compare
|
Deleted extra newline. |
soapy1
suggested changes
Mar 24, 2020
When user is using podman's docker CLI emulation the containers would fail to enter running state because the docker driver could not catch the container name. This commit fixes that by adding a check if podman docker emulation is used and pick the container hash correctly from the output.
jackorp
force-pushed
the
vagrant-podman-container-build
branch
from
eb30324
to
5208032
Compare
soapy1
approved these changes
Mar 30, 2020
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user is using podman's docker CLI emulation the containers would
fail to enter running state because the docker driver could not catch
the container name. This commit fixes that by adding a check if podman
docker emulation is used and pick the container hash correctly from the
output.