Ignore possible version directories that are hidden folders. #4758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -224,7 +224,7 @@ def all | |||
| # Otherwise, traverse the subdirectories and see what versions | |||
| # we have. | |||
| child.children(true).each do |versiondir| | |||
| next if !versiondir.directory? | |||
| next if !versiondir.directory? || versiondir.basename.to_s[0] == '.' | |||
There was a problem hiding this comment.
I think we can make this a little clearer using start_with?:
versiondir.basename.start_with?(".")There was a problem hiding this comment.
I also think we should move this check onto its own line:
next if !versiondir.directory?
next if versiondir.basename.start_with?(".") # Ignore hidden directories
|
Hi @philwrenn Thank you for the PR, and I am sorry it has taken a bit for us to get you a review. Overall this looks pretty good to me. I left a few comments in the PR - let me know what you think. |
|
I made the changes you suggested. |
|
@sethvargo I attempted made the changes you suggested, but I couldn't get build to complete.. Honestly I don't really work with ruby. I just ran into an issue and was lucky enough to get it working. If this isn't bugging anyone else you can just decline the request. This is no longer an issue for me. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use a synchronization tool to sync my boxes between my laptop and desktop. This prevents me from having to download the same box version twice from vagrant cloud. My sync tool, like may others, creates a hidden folder to store sync related data and conflicted files. It would be nice if vagrant would not mistakenly identify the hidden folder as a version folder.