Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore hidden directories #5785

Merged
merged 2 commits into from
Jun 2, 2015
Merged

Ignore hidden directories #5785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c8fe42
Ignore possible version directories that are hidden folders, i.e. dot…
philwrenn Oct 31, 2014
3459358
Style fixes
sethvargo Jun 2, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/vagrant/box_collection.rb
View file
Open in desktop
Expand Up @@ -225,6 +225,7 @@ def all
# we have.
child.children(true).each do |versiondir|
next if !versiondir.directory?
next if versiondir.basename.to_s.start_with?(".")

version = versiondir.basename.to_s

Expand Down Expand Up @@ -270,6 +271,8 @@ def find(name, providers, version)

versions = box_directory.children(true).map do |versiondir|
next if !versiondir.directory?
next if versiondir.basename.to_s.start_with?(".")

version = versiondir.basename.to_s
Gem::Version.new(version)
end.compact
Expand Down
2 changes: 1 addition & 1 deletion vagrant.gemspec
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@ Gem::Specification.new do |s|
s.required_rubygems_version = ">= 1.3.6"
s.rubyforge_project = "vagrant"

s.add_dependency "bundler", ">= 1.5.2", "< 1.8.0"
s.add_dependency "bundler", ">= 1.5.2"#, "< 1.8.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the comment intented? E.g. will the constraint be re-added soon or will it be gone for good?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, thank you for catching it. It will updated soon, but not yet 😄

s.add_dependency "childprocess", "~> 0.5.0"
s.add_dependency "erubis", "~> 2.7.0"
s.add_dependency "i18n", ">= 0.6.0", "<= 0.8.0"
Expand Down