Split out cygwin path and ensure bin exists #8972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good -- looking forward to trying it. Thanks, @briancain |
|
Hey @narration-sd - just an fyi, this PR will mostly be focusing on fixing #8954 . The issue you reported will be fixed in a vagrant-installers PR just to ensure we are detecting cygwin properly. |
briancain
force-pushed
the
update-cygwin-path-functions
branch
from
26e092e
to
60e1944
Compare
This commit splits out the msys2 and cygwin path functions for expanding a path with the cygpath tool. It also ensures that the tool itself exists when the Which class is called so that it doesn't attempt to escape slashes on nil.
briancain
force-pushed
the
update-cygwin-path-functions
branch
from
60e1944
to
3c9e1c9
Compare
chrisroberts
approved these changes
Sep 28, 2017
This was referenced Oct 3, 2017
Closed
|
My apologies, this PR has been merged but not released and affects a lot of people on Windows. Any plans to put it in release section? |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit splits out the msys2 and cygwin path functions for
expanding a path with the cygpath tool. It also ensures that the tool
itself exists when the Which class is called so that it doesn't attempt
to escape slashes on nil.
Fixes #8954