Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyper V Provider, handle multiple attached VHDs for XML configs #9026

Closed
wants to merge 3 commits into from

Conversation

simonp22
Copy link

@simonp22 simonp22 commented Oct 3, 2017

Was creating a Hyper V box where I needed to attach multiple VHDs.

These code changes copy all VHDs from the "Virtual Hard Disks" folder in the box, then loops through the drives in the XML config for the box and adds them in the correct order

@bbrala
Copy link
Contributor

bbrala commented Oct 5, 2017

@simonp22 i actually think that if you you a gen 2 virtual machine, it would already work, since it really clones the original and makes some adjustments instead of building one from an XML file manually.

@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@briancain
Copy link
Member

Hey there everyone! I'm going to go ahead and close this issue, as I have just made a pull request that takes advantage of the recent generic disk config options in Vagrant. You can find that PR here: #11541 It offers a lot of extra goodies such as resizing disks (similar to the VirtualBox implementation). Thanks!

@briancain briancain closed this Apr 22, 2020
@ghost
Copy link

ghost commented May 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@hashicorp hashicorp locked and limited conversation to collaborators May 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants