Add Secret Engine for LDAP #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltcarbonell
requested review from
jasonodonnell and
elliesterner
and removed request for
a team
ltcarbonell
force-pushed
the
ldap-secret-engine-v2
branch
from
de7dd80
to
738edbc
Compare
ltcarbonell
commented
May 19, 2023
…nchmark into ldap-secret-engine-v2
benchmarktests/target_secret_ldap.go
Outdated
| }, | ||
| }, | ||
| } | ||
|
|
There was a problem hiding this comment.
Missing error message for environment variable and config not set, error out.
|
@ltcarbonell This implementation looks to only be the dynamic credentials api for the secret engine (https://developer.hashicorp.com/vault/api-docs/secret/ldap#dynamic-role-passwords) but this secret engine also supports static roles (https://developer.hashicorp.com/vault/api-docs/secret/ldap#static-roles). I think we need to change the name of some structs and docs to call this out. |
elliesterner
reviewed
Jun 1, 2023
elliesterner
reviewed
Jun 1, 2023
| func (r *LDAPStaticSecretTest) Setup(client *api.Client, randomMountName bool, mountName string) (BenchmarkBuilder, error) { | ||
| var err error | ||
| secretPath := mountName | ||
| r.logger = targetLogger.Named(LDAPDynamicSecretTestType) |
There was a problem hiding this comment.
should this be static?
There was a problem hiding this comment.
Yeah let me add this
elliesterner
reviewed
Jun 1, 2023
Co-authored-by: Ellie <ellie.sterner@hashicorp.com>
elliesterner
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the LDAP secret engine benchmark tests