Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nomad Secret Engine Tests #125

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Add Nomad Secret Engine Tests #125

merged 3 commits into from
Jun 2, 2023

Conversation

ltcarbonell
Copy link
Contributor

Adds the Nomad secret engine benchmark tests

@ltcarbonell ltcarbonell requested a review from a team as a code owner June 1, 2023 16:03
@ltcarbonell ltcarbonell requested review from jasonodonnell and elliesterner and removed request for a team June 1, 2023 16:03

#### NOTE: Ensure that the Nomad system has a limit high enough to support the number of roles you are creating. More information can be found in the [Nomad Documentation](https://developer.hashicorp.com/nomad/docs/configuration#limits)

- `address` `(string: "")` – Specifies the address of the Nomad instance, provided as `"protocol://host:port"` like `"http://127.0.0.1:4646"`. This value can also be provided on individual calls with the NOMAD_ADDR environment variable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does NOMAD_ADDR work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesnt currently. But ill remove this

@ltcarbonell ltcarbonell merged commit c916879 into main Jun 2, 2023
26 checks passed
@ltcarbonell ltcarbonell deleted the nomad-secret-engine branch June 2, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants