Add gcp auth target #131
Merged
Add gcp auth target #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliesterner
commented
Jul 10, 2023
elliesterner
requested review from
ltcarbonell,
davidadeleon and
jasonodonnell
and removed request for
a team
ltcarbonell
requested changes
Jul 13, 2023
Co-authored-by: Luis (LT) Carbonell <lt.carbonell@hashicorp.com>
ltcarbonell
approved these changes
Jul 13, 2023
Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>
Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>
Closed
jasonodonnell
approved these changes
Jul 20, 2023
ltcarbonell
added a commit
that referenced
this pull request
Jul 24, 2023
* rebase * add getSignedJwt function * add back context * add randomness to signin * updgrade deps * add documentation * remove ldap ref * switch position * fix spacing * replace func * fix params * make sure proper token is signed based on iam vs gce * Update benchmarktests/target_auth_gcp.go Co-authored-by: Luis (LT) Carbonell <lt.carbonell@hashicorp.com> * Update benchmarktests/target_auth_gcp.go Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com> * Update benchmarktests/target_auth_gcp.go Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com> * cleanup config * fix name --------- Co-authored-by: Luis (LT) Carbonell <lt.carbonell@hashicorp.com> Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified this also works in GCP VM