Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure dockertests are running against most up to date benchmark binary instead of latest docker tag #136

Merged
merged 4 commits into from
Jul 24, 2023
Merged

Ensure dockertests are running against most up to date benchmark binary instead of latest docker tag #136

merged 4 commits into from
Jul 24, 2023

Conversation

elliesterner
Copy link
Contributor

@elliesterner elliesterner commented Jul 13, 2023 •
edited
Loading 

// create binary for docker
make dockerbin

// set BENCHMARK_BINARY 
export BENCHMARK_BINARY=$(pwd)/dist/linux/amd64/vault-benchmark

// run tests
cd test-fixtures && cd test-fixtures && go test -v  -count=1 ./...

// cleanup images so we don't accidentally run tests with old version of benchmark binary
cd .. && make cleanupimages

@elliesterner elliesterner requested a review from a team as a code owner July 13, 2023 22:20
@elliesterner elliesterner requested review from jasonodonnell and ltcarbonell and removed request for a team July 13, 2023 22:20
davidadeleon
davidadeleon approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@davidadeleon davidadeleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Small nit, but nothing stopping the merge.

helper/dockertest/dockerjobs/benchmark_run.go Show resolved Hide resolved
@elliesterner elliesterner merged commit c6618aa into main Jul 24, 2023
22 checks passed
@elliesterner elliesterner deleted the customer-vault-bin branch August 9, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonodonnell jasonodonnell jasonodonnell approved these changes

@ltcarbonell ltcarbonell ltcarbonell approved these changes

@davidadeleon davidadeleon davidadeleon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@elliesterner @jasonodonnell @ltcarbonell @davidadeleon