Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send query parameters to the Vault API using correct names #207

Merged
merged 3 commits into from
Jul 25, 2023

Conversation

maxb
Copy link
Contributor

@maxb maxb commented Jul 25, 2023

They were incorrectly being rendered converted to camelCase instead of
Vault's native snake_case.

They were incorrectly being rendered converted to camelCase instead of
Vault's native snake_case.
@maxb maxb requested a review from a team July 25, 2023 05:56
Copy link
Collaborator

@averche averche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@maxb
Copy link
Contributor Author

maxb commented Jul 25, 2023

Conflicts resolved.

@averche averche merged commit 451d494 into hashicorp:main Jul 25, 2023
4 checks passed
@maxb maxb deleted the queryparam-camelcase-bug branch July 25, 2023 15:43
@averche averche mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants