Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the generated docs, add missing schema. to code samples #223

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

maxb
Copy link
Contributor

@maxb maxb commented Jul 29, 2023

Also refactor the affected portion of the Handlebars templates to use
whitespace control, which hopefully makes it more readable, as the
control tags for one thing to output are no longer concatenated on the
same line as literal text from the previous thing to output.

Also refactor the affected portion of the Handlebars templates to use
whitespace control, which hopefully makes it more readable, as the
control tags for one thing to output are no longer concatenated on the
same line as literal text from the previous thing to output.
@maxb maxb requested a review from a team July 29, 2023 22:01
Copy link
Collaborator

@averche averche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, good catch 👍

Comment on lines +43 to +44
{{! Oddly, vendorExtensions.x-go-example seems to only be available within allParams,
and not within pathParams, queryParams, etc. }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL handlebars allows for comments :)

@averche averche merged commit 7efc077 into hashicorp:main Jul 30, 2023
4 checks passed
@maxb maxb deleted the docs-fix-schema branch July 30, 2023 23:16
@averche averche mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants