Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync OpenAPI: Miscellaneous changes from Vault 1.15.0-dev #230

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

maxb
Copy link
Contributor

@maxb maxb commented Aug 28, 2023

We are now back generating from the Vault main branch, as the three plugin version bumps we'd been waiting for are finally done.

Reminder: we are still carrying a local modification to the Vault source
tree when generating OpenAPI of
```
go get github.com/hashicorp/vault-plugin-{secrets-{gcp,kv},auth-jwt}@main
go mod tidy
```
whilst we wait for those plugins to be updated in the main Vault tree.
@maxb maxb requested a review from a team as a code owner August 28, 2023 14:23
Copy link
Collaborator

@averche averche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for contributing, @maxb!

P.S. Sorry took a while to approve as I was out of town on vacation.

@averche averche merged commit 1bad0b3 into hashicorp:main Sep 11, 2023
4 checks passed
@maxb maxb deleted the sync-openapi branch September 11, 2023 23:17
@maxb
Copy link
Contributor Author

maxb commented Sep 12, 2023

Not a problem :-)

Are you able to take care of the equivalent .NET PR too? hashicorp/vault-client-dotnet#163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants